Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KMSv2] Use status key ID to determine staleness of encrypted data #111922

Closed
enj opened this issue Aug 18, 2022 · 6 comments · Fixed by #114544
Closed

[KMSv2] Use status key ID to determine staleness of encrypted data #111922

enj opened this issue Aug 18, 2022 · 6 comments · Fixed by #114544
Assignees
Labels
sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@enj
Copy link
Member

enj commented Aug 18, 2022

Today you need multiple encryption providers to communicate to the API server if data stored in etcd is stale (i.e. the KMS v1beta1 API has no way to communicate staleness). The KMS v2 API includes a key ID in the status API to allow for such a check to be performed. We need to wire the knowledge of the current key ID into the envelope encryption code.

xref: #111126 (comment)

/assign
/milestone v1.26
/sig auth
/triage accepted

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Aug 18, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Aug 18, 2022
@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Aug 18, 2022
@enj enj added this to Needs Triage in SIG Auth Old Sep 12, 2022
@cailynse
Copy link

Hi @enj! Release Bug Triage Shadow here - I just wanted to see if this is still on track for the 1.26 release? It looks like you have made lots of progress!

@enj enj moved this from Needs Triage to In Progress in SIG Auth Old Oct 3, 2022
@enj
Copy link
Member Author

enj commented Oct 11, 2022

@cailynse yup I am hoping to have this sorted before KubeCon :)

@cailynse
Copy link

cailynse commented Nov 2, 2022

Hey! @enj - checking in again to see if there are any updates

@enj enj moved this from In Progress to Backlog in SIG Auth Old Nov 2, 2022
@enj
Copy link
Member Author

enj commented Nov 2, 2022

@cailynse I am going to push this out to next release because the associated refactors took a long time to merge and some are still in-flight for v1.26.

/milestone v1.27

@k8s-ci-robot
Copy link
Contributor

@enj: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.16, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23, v1.24, v1.25, v1.26]

Use /milestone clear to clear the milestone.

In response to this:

@cailynse I am going to push this out to next release because the associated refactors took a long time to merge and some are still in-flight for v1.26.

/milestone v1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.26, next-candidate, v1.27 Nov 2, 2022
@enj
Copy link
Member Author

enj commented Nov 29, 2022

/assign @ritazh
/unassign @enj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants