New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix godocs autoformatting from upgrading to go 1.19 #111701
Comments
@Jefftree: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Jefftree: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assgin @sanwishe |
/sig docs |
/assign |
/assign |
I won't be able to work on this, due to other work commitments. Hence, unassigning myself, anyone feel free to take upon this issue. |
Created #114559 to resolve this |
What happened?
Reference Comment: #111254 (comment)
Based on the diff: https://github.com/kubernetes/kubernetes/pull/111254/files, there are a couple areas where indentations are turned into paragraphs, indentations are turning regular comments into code blocks, etc.
I think there are a couple things we need to do (could be in separate PRs):
*
to use-
. go1.19 does not recognize*
as bullet points. For example: https://github.com/dims/kubernetes/blob/a9593d634c6a053848413e600dadbf974627515f/staging/src/k8s.io/api/core/v1/types.go#L495-L496I hope this roughly captures the intent of the comment by liggitt.
/cc @liggitt
/cc @dims
/help
What did you expect to happen?
See above
How can we reproduce it (as minimally and precisely as possible)?
See above
Anything else we need to know?
No response
Kubernetes version
Cloud provider
OS version
Install tools
Container runtime (CRI) and version (if applicable)
Related plugins (CNI, CSI, ...) and versions (if applicable)
The text was updated successfully, but these errors were encountered: