structured logging: switch from KObjs to KObjSlice

[pohly]

What would you like to be added?

kubernetes/klog#322 added klog.KObjSlice as replacement for klog.KObjs. A version of klog with that is now in Kubernetes master.

We should:

• Search/replace calls to KObjs in all of Kubernetes.
• In places where the if klogV := klog.V(5); klogV.Enabled() { klogV.Info(..., klog.KObjs(...) } pattern was used, consider whether a direct klog.V(5).Info(..., klog.KObjSlice(...)) call can be used instead. This is okay if there are no other parameters that are expensive to compute.
• Update https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md.
• When this is done, extend https://github.com/kubernetes-sigs/logtools to complain about usage of klog.KObjs. This is optional. A better way would be to enable pre-merge linting where usage of any deprecated function becomes merge-blocking (see verify-golangci-lint.sh: support stricter checking in new code #109728).

/sig instrumentation
/wg structured-logging

Why is this needed?

klog.KObjSlice takes constant time when called to prepare the parameter, in contrast to klog.KObjs which is linear with the number of entries it needs to handle.

[pohly]

When preparing a PR which removes KObj, remember to include a meaningful "why this is needed" in the PR description itself, for example the one above. A link to this issue should be added for cross-reference, but that alone is not enough for reviewers because it makes them do extra work (look up an issue and read through all of it).

[harshanarayana]

/assign

Can I take this one up ?

[pohly]

Yes, please do.

[yangjunmyfm192085]

/assign
I can take one of these
Could we be together？@harshanarayana

[yangjunmyfm192085]

I can work on this Search/replace calls to KObjs in all of Kubernetes.

[harshanarayana]

Could we be together？

Certainly.

@yangjunmyfm192085 I just finished the first one and half way through the second. The other two I have not yet taken a look into. Mind taking one of those two ?

[yangjunmyfm192085]

Let me update the third one. thanks a lot

[dgrisonnet]

/triage accepted

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[harshanarayana]

/remove-lifecycle stale