Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #96882: Make parallel build memory threshold configurable #101366

Merged
merged 1 commit into from Apr 27, 2021
Merged

Automated cherry pick of #96882: Make parallel build memory threshold configurable #101366

merged 1 commit into from Apr 27, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Apr 22, 2021

Cherry pick of #96882 on release-1.18.

#96882: Make parallel build memory threshold configurable

For details on the cherry pick process, see the cherry pick requests page.

@saschagrunert @xmudrii
Make parallel build memory threshold configurable
28818d5 
The amount of memory required to build binaries in parallel is right now
set to 40GiB. We now make this variable to be able to build artifacts in
parallel even with a lower amount of memory.

This enables SIG Release to speed-up the build time drastically in
Google Cloud Build (GCB).

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Apr 22, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 22, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 22, 2021
@xmudrii
Copy link
Member Author

xmudrii commented Apr 22, 2021

From #101363 (comment):

This is a proposal that we cherry-pick the change that allows us to build in parallel to other release branches. Right now, we have it on the release-1.21 branch, and it seems to work very well. This speeds up the release process by ~10 minutes.

This is a result of the following Slack discussion: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1619032489004200
We've thought that it would make sense to cherry-pick this to the supported release branches, so the release times are consistent across all branches.

This yet to be tested, but I'm not sure that it's possible to properly test it before the PR is merged.

/sig release
/area release-eng
/assign @BenTheElder @spiffxp @saschagrunert
/priority important-soon
/triage accepted
/kind cleanup
/release-note-none
cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 22, 2021
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 22, 2021
@xmudrii xmudrii mentioned this pull request Apr 22, 2021
Closed
spiffxp
spiffxp approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2021
@saschagrunert saschagrunert added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Apr 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, spiffxp, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

/test pull-kubernetes-node-e2e

1 similar comment
@xmudrii
Copy link
Member Author

xmudrii commented Apr 27, 2021

/test pull-kubernetes-node-e2e

@k8s-ci-robot k8s-ci-robot merged commit 54377e0 into kubernetes:release-1.18 Apr 27, 2021
@xmudrii xmudrii deleted the automated-cherry-pick-of-#96882-upstream-release-1.18 branch April 27, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@mikedanese mikedanese Awaiting requested review from mikedanese

@xichengliudui xichengliudui Awaiting requested review from xichengliudui

Assignees

@spiffxp spiffxp

@saschagrunert saschagrunert

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xmudrii @k8s-ci-robot @saschagrunert @spiffxp @BenTheElder