New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #99336: pkg/kubelet: improve the node informer sync check #101343
Automated cherry pick of #99336: pkg/kubelet: improve the node informer sync check #101343
Conversation
GetNode() is called in a lot of places including a hot loop in fastStatusUpdateOnce. Having a poll in it is delaying the kubelet /readyz status=200 report. If a client is available attempt to wait for the sync to happen, before starting the list watch for pods at the apiserver.
/kind bug @kubernetes/release-managers |
/retest |
/lgtm |
will there be another 1.18 release? I thought it will be EOL before the next wave of patch releases: https://github.com/kubernetes/sig-release/blob/master/releases/patch-releases.md#118 |
/triage accepted |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, neolit123, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #99336 on release-1.18.
#99336: pkg/kubelet: improve the node informer sync check
For details on the cherry pick process, see the cherry pick requests page.