Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show patch strategy in kubectl explain #1551

Open
xlucas opened this issue Jan 26, 2024 · 8 comments · May be fixed by kubernetes/kubernetes#123073
Open

Show patch strategy in kubectl explain #1551

xlucas opened this issue Jan 26, 2024 · 8 comments · May be fixed by kubernetes/kubernetes#123073
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@xlucas
Copy link

xlucas commented Jan 26, 2024

What would you like to be added?

Show patch strategy metadata (ie patchStrategy, patchMergeKey and so on as covered in https://kubernetes.io/docs/tasks/manage-kubernetes-objects/update-api-object-kubectl-patch) in kubectl explain.

Why is this needed?

This information is very important to users since it could lead to unexpected results while patching object fields but alas only shown in the full API reference. It'd be helpful to see it with kubectl explain directly.

@xlucas xlucas added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 26, 2024
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 26, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 26, 2024
@pranav-pandey0804
Copy link

/sig cli

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 26, 2024
@pranav-pandey0804
Copy link

Hi @xlucas ,
Great idea on enhancing kubectl explain with patch strategy info. This could clarify resource updates for users. Suggesting a discussion in SIG CLI to gather more insights and potentially refine this idea. I'm interested in how this evolves and may contribute as it moves forward.

@ah8ad3
Copy link
Member

ah8ad3 commented Jan 28, 2024

Hi folks,
I was also looking at the issue and in middle of checking the kubectl explain i saw and message in
kubectl explain deployment.spec.template.spec
due to update-api-object-kubectl-patch we can add new containers via different patch strategies but in message this is what i saw

  containers	<[]Container> -required-
    List of containers belonging to the pod. Containers cannot currently be
    added or removed. There must be at least one container in a Pod. Cannot be
    updated.

also i can help with resolving this issue if it get triange accepted.

@HirazawaUi
Copy link
Contributor

/transfer kubectl

@k8s-ci-robot k8s-ci-robot transferred this issue from kubernetes/kubernetes Jan 28, 2024
@mpuckett159
Copy link
Contributor

This sounds great. Thank you for helping update the explain outputs.
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 31, 2024
@ah8ad3
Copy link
Member

ah8ad3 commented Feb 1, 2024

/assign

@sftim
Copy link
Contributor

sftim commented Apr 23, 2024

/retitle Show patch strategy in kubectl explain

@k8s-ci-robot k8s-ci-robot changed the title Show patch strategy in kubectl explain Show patch strategy in kubectl explain Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Needs Triage
Development

Successfully merging a pull request may close this issue.

7 participants