Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git shallow clone when applying configuration from GitHub url #1031

Closed
jgallucci32 opened this issue Mar 12, 2021 · 3 comments
Closed

Use git shallow clone when applying configuration from GitHub url #1031

jgallucci32 opened this issue Mar 12, 2021 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@jgallucci32
Copy link

What would you like to be added:
When applying a configuration using a direct GitHub url, it appears to be cloning the entire git repository which depending on the project can cause delays (and in some cases timeout) during the operation. An example is applying the Kustomization for the CSI driver for Amazon EBS as follows

kubectl apply -k "github.com/kubernetes-sigs/aws-ebs-csi-driver/deploy/kubernetes/overlays/stable/?ref=release-0.9"

For this particular environment, the WAN is very limited and cloning the entire git repository times. When using a git shallow clone (i.e. git clone --depth=1) only the branch is checked out and the clone operation succeeds in a few seconds.

Why is this needed:
Projects increasingly rely on pulling software install packages directly from GitHub rather than a package management system and it causes significant delays cloning an entire repository to obtain these files needed for install. Since only a specific branch or tag is required when applying a configuration using the kubectl command, the git operation should be using a shallow clone to speed up the process.

@jgallucci32 jgallucci32 added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 12, 2021
@k8s-ci-robot
Copy link
Contributor

@jgallucci32: This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 12, 2021
@eddiezane
Copy link
Member

The baked in version of kustomize was upgraded to v4 and this should be fixed. It will ship with kubectl v 1.21.

If for some reason it's not please reopen on the kustomize repo.

/close

@k8s-ci-robot
Copy link
Contributor

@eddiezane: Closing this issue.

In response to this:

The baked in version of kustomize was upgraded to v4 and this should be fixed. It will ship with kubectl v 1.21.

If for some reason it's not please reopen on the kustomize repo.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

3 participants