Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License Scan and Findings #16366

Open
10 of 11 tasks
pacoxu opened this issue Feb 19, 2024 · 6 comments
Open
10 of 11 tasks

License Scan and Findings #16366

pacoxu opened this issue Feb 19, 2024 · 6 comments

Comments

@pacoxu
Copy link
Member

pacoxu commented Feb 19, 2024

This code is under the MPL-2.0 license which is weak copyleft. Be sure that it is used only as dynamic libraries, to be safe if it's not required remove it from your repo.

Like https://github.com/kubernetes/kubernetes/blob/master/hack/unwanted-dependencies.json

@jeffcshapiro
Copy link

Per Bob Killen @mrbobbytables
All of these EXCEPT kubernetes-2024-01-03.zip/kops/vendor/github.com/hashicorp/memberlist/LICENSE
have been granted a license exception approval:

cncf-exceptions-2019-11-01.spdx
github.com/hashicorp/errwrap - PackageComment: not auto-allowlist because: Non-allowlist license(s); approved by GB exception 2019-03-11
github.com/hashicopr/go-cleanhttp - PackageComment: not auto-allowlist because: Non-allowlist license(s); approved by GB exception 2019-03-11
github.com/hashicopr/go-multierror - PackageComment: not auto-allowlist because: Non-allowlist license(s); approved by GB exception 2019-03-11
github.com/hashicopr/golang-lru - PackageComment: not auto-allowlist because: Non-allowlist license(s); approved by GB exception 2019-03-11
github.com/hashicopr/hcl - PackageComment: not auto-allowlist because: Non-allowlist license(s); approved by GB exception 2019-03-11

cncf-exceptions-2021-07-19.spdx
github.com/hashicopr/go-retryablehttp - PackageComment: not auto-allowlist because: Non-allowlist license(s); approved by GB exception 2021-07-19

cncf-exceptions-2023-06-27.spdx
github.com/hashicopr/go-sockaddr - PackageComment: not auto-allowlist because: Non-allowlist license(s); approved by GB exception 2023-06-27
github.com/hashicopr/go-immutable-radix - PackageComment: not auto-allowlist because: Non-allowlist license(s); approved by GB exception 2023-06-27

You should request an exception for memberlist or remove the code.

@pacoxu
Copy link
Member Author

pacoxu commented Feb 29, 2024

update the todo list

@pacoxu
Copy link
Member Author

pacoxu commented Feb 29, 2024

This is used in

cluster "github.com/jacksontj/memberlistmesh"
"github.com/prometheus/client_golang/prometheus"

	cluster "github.com/jacksontj/memberlistmesh"

github.com/jacksontj/memberlistmesh used github.com/hashicorp/memberlist.

/cc @jacksontj @justinsb

@hakman
Copy link
Member

hakman commented Mar 1, 2024

@pacoxu memberlistmesh is an important piece of the Gossip implementation in kOps at the moment. There is a plan to remove it in a year or so, but not immediate.
How can we obtain an exception for now?

@mrbobbytables
Copy link
Member

@hakman there is a license exception request issue template in the cncf/foundation repo: https://github.com/cncf/foundation/issues/new/choose

It'll need review from the legal committee and approval from the GB to be added as an exception.

@hakman
Copy link
Member

hakman commented Mar 1, 2024

Thanks @mrbobbytables & @pacoxu. I created a new request for github.com/hashicorp/memberlist:
cncf/foundation#741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants