Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies between qualified names on AWS nodes #16349

Open
rifelpet opened this issue Feb 11, 2024 · 2 comments
Open

Inconsistencies between qualified names on AWS nodes #16349

rifelpet opened this issue Feb 11, 2024 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/office-hours lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@rifelpet
Copy link
Member

/kind bug
/kind failing-test

Our grid jobs for RHEL-based distros are failing a test that was recently unskipped for unrelated reasons (#16176)

https://testgrid.k8s.io/kops-grid#kops-grid-cilium-amzn2-k28

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/e2e-kops-grid-cilium-amzn2-k28/1756260864102502400

[FAIL] [sig-network] Networking Granular Checks: Services [It] should function for service endpoints using hostNetwork 
   [FAILED] failed dialing endpoint, did not find expected responses... 
  Tries 46
  Command curl -g -q -s 'http://100.96.4.93:9080/dial?request=hostname&protocol=http&host=100.66.81.213&port=80&tries=1'
  retrieved map[i-03b17693021906ac2.eu-west-1.compute.internal:{} i-03fbc6f079db37ce7.eu-west-1.compute.internal:{} i-0c90e87e766b90952.eu-west-1.compute.internal:{} i-0fd0d694876a8befc.eu-west-1.compute.internal:{}]
  expected map[i-03b17693021906ac2:{} i-03fbc6f079db37ce7:{} i-0c90e87e766b90952:{} i-0fd0d694876a8befc:{}]

This test expects unqualified names but is actually receiving fully qualified names. The test code's expected data comes from the kubernetes.io/hostname label on nodes (also the node name itself) which we see is the unqualified instance ID.

The test's actual data comes from running the hostname command on a hostNetwork pod.

A list of our distros and whether hostname returns a fully qualified name:

  • AL 2 - yes
  • AL 2023 - yes
  • Debian 10 - no
  • Debian 12 - no
  • Flatcar - no
  • RHEL 8 - yes
  • RHEL 9 - yes
  • Rocky 8 - yes
  • Ubuntu 20.04 - no
  • Ubuntu 22.04 - no

I think our best path forward would be to configure the RHEL-based distros to return the unqualified name for hostname. This would match behavior with the other distros.

Alternatively we could make all node names fully qualified like i-03fbc6f079db37ce7.eu-west-1.compute.internal but this feels more disruptive.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Feb 11, 2024
@rifelpet
Copy link
Member Author

This relates to kubernetes/kubernetes#121018 and the e2e test logic could be updated to handle either qualified or unqualified hostname outputs.

/kind office-hours

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/office-hours lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants