StartFlushDaemon: add API with more control over flushing #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, periodic flushing was started automatically when writing to buffered files for the first time. When writing to a Logger which buffers internally, then using the same periodic flushing makes sense. In that case it has to be started explicitly. The new call grants the caller control over the flush interval. Kubernetes has a parameter for that.
|
/hold Let's do a full test run with this code in Kubernetes: kubernetes/kubernetes#108725 |
pohly
commented
Mar 16, 2022
| StopFlushDaemon() | ||
| logging.flushD.run(interval) | ||
| } | ||
|
|
There was a problem hiding this comment.
This gets used in Kubernetes like this:
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
do-not-merge/hold
|
/assign @thockin @serathius |
|
/hold cancel Test in Kubernetes with usage of the new API call was successful. |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, pohly, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
What this PR does / why we need it:
Previously, periodic flushing was started automatically when writing to
buffered files for the first time. When writing to a Logger which buffers
internally, then using the same periodic flushing makes sense. In that case it
has to be started explicitly.
The new call grants the caller control over the flush interval. Kubernetes has
a parameter for that.
Special notes for your reviewer:
This will be used to fix a race condition that was found in Kubernetes' own periodic flushing.
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: