Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logr has tagged v1.0.0-rc1 #241

Closed
thockin opened this issue May 29, 2021 · 7 comments
Closed

logr has tagged v1.0.0-rc1 #241

thockin opened this issue May 29, 2021 · 7 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@thockin
Copy link
Member

thockin commented May 29, 2021

/kind feature

logr made BREAKING CHANGES for implementations to prep for 1.0.0

I know this impl was derived from glogr, so here's the glogr PR that adopts the new logr API changes: go-logr/glogr#13 - this includes a bunch of perf-related changes too.

The changes are not THAT complicated. Please feel free to shout if they don't make sense.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 29, 2021
@dims
Copy link
Member

dims commented May 29, 2021

looks like the diff for logr is as shown here: go-logr/logr@v0.4.0...v1.0.0-rc1

@dims
Copy link
Member

dims commented May 29, 2021

/assign @dims

@thockin
Copy link
Member Author

thockin commented May 29, 2021 via email

@thockin
Copy link
Member Author

thockin commented Jul 6, 2021

logr v1.0.0 has been tagged. No changes since rc1.

@morlay
Copy link

morlay commented Aug 11, 2021

Hi. Have a new release?

Block kubernetes-sigs/controller-runtime#1593

@pohly
Copy link

pohly commented Sep 10, 2021

v2.20.0 uses logr v1.1.0.

/close

@k8s-ci-robot
Copy link

@pohly: Closing this issue.

In response to this:

v2.20.0 uses logr v1.1.0.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants