From ff7c070ad572af0e5e7b4b842f893a60ac6b4151 Mon Sep 17 00:00:00 2001
From: Patrick Ohly <patrick.ohly@intel.com>
Date: Mon, 11 Mar 2024 09:34:31 +0100
Subject: [PATCH] build: fix some linter warnings

revive in golangci-lint has version v1.56.2 complains about unused named
parameters. Sometimes names are useful to document the purpose of a
parameter. Comments are used instead now in those cases.
---
 contextual_slog_example_test.go | 2 +-
 klogr/output_test.go            | 2 +-
 output_test.go                  | 2 +-
 test/output.go                  | 2 +-
 textlogger/textlogger_test.go   | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/contextual_slog_example_test.go b/contextual_slog_example_test.go
index 0c2ba41a..595d9835 100644
--- a/contextual_slog_example_test.go
+++ b/contextual_slog_example_test.go
@@ -31,7 +31,7 @@ func ExampleSetSlogLogger() {
 	defer state.Restore()
 
 	handler := slog.NewTextHandler(os.Stdout, &slog.HandlerOptions{
-		ReplaceAttr: func(groups []string, a slog.Attr) slog.Attr {
+		ReplaceAttr: func(_ /* groups */ []string, a slog.Attr) slog.Attr {
 			if a.Key == slog.TimeKey {
 				// Avoid non-deterministic output.
 				return slog.Attr{}
diff --git a/klogr/output_test.go b/klogr/output_test.go
index aa87e953..d634daa6 100644
--- a/klogr/output_test.go
+++ b/klogr/output_test.go
@@ -30,7 +30,7 @@ import (
 func TestKlogrOutput(t *testing.T) {
 	test.InitKlog(t)
 	test.Output(t, test.OutputConfig{
-		NewLogger: func(out io.Writer, v int, vmodule string) logr.Logger {
+		NewLogger: func(_ io.Writer, _ int, _ string) logr.Logger {
 			return klogr.NewWithOptions(klogr.WithFormat(klogr.FormatKlog))
 		},
 	})
diff --git a/output_test.go b/output_test.go
index c5434d60..124796d3 100644
--- a/output_test.go
+++ b/output_test.go
@@ -41,7 +41,7 @@ func BenchmarkKlogOutput(b *testing.B) {
 
 // klogKlogrConfig tests klogr output via klog, using the klog/v2 klogr.
 var klogKLogrConfig = test.OutputConfig{
-	NewLogger: func(out io.Writer, v int, vmodule string) logr.Logger {
+	NewLogger: func(_ io.Writer, _ int, _ string) logr.Logger {
 		return klog.NewKlogr()
 	},
 }
diff --git a/test/output.go b/test/output.go
index da80b81a..1857f500 100644
--- a/test/output.go
+++ b/test/output.go
@@ -584,7 +584,7 @@ func Output(t *testing.T, config OutputConfig) {
 
 			if config.NewLogger == nil {
 				// Test klog.
-				testOutput(t, printWithKlogLine-1, func(buffer *bytes.Buffer) {
+				testOutput(t, printWithKlogLine-1, func(_ *bytes.Buffer) {
 					printWithKlog(test)
 				})
 				return
diff --git a/textlogger/textlogger_test.go b/textlogger/textlogger_test.go
index b2e15b5d..1c79c751 100644
--- a/textlogger/textlogger_test.go
+++ b/textlogger/textlogger_test.go
@@ -82,7 +82,7 @@ func ExampleBacktrace() {
 	backtraceCounter := 0
 	config := textlogger.NewConfig(
 		textlogger.FixedTime(ts), // To get consistent output for each run.
-		textlogger.Backtrace(func(skip int) (filename string, line int) {
+		textlogger.Backtrace(func(_ /* skip */ int) (filename string, line int) {
 			backtraceCounter++
 			if backtraceCounter == 1 {
 				// Simulate "missing information".