[KEP-3085] Add condition for sandbox creation (xposted from original issue)

[kannon92]

This is a repost of #3085 as we want to keep this up to date.

Enhancement Description

• One-line enhancement description (can be used as a release note): Surface pod conditions around completion of pod sandbox creation marked by successful network configuration for the pod.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/3085-pod-conditions-for-starting-completition-of-sandbox-creation
• Discussion Link: SIG Node Agenda
• Primary contact (assignee): @kannon92 (@ddebroy is original author)
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha1 release target (x.y): 1.25
  • Alpha2 release target (x.y): 1.28
  • Beta release target (x.y): 1.29-1.30
  • Stable release target (x.y):
• Alpha1 (1.25)
  • KEP (k/enhancements) update PR(s):
    • KEP-3085: Add KEP for Pod network ready condition #3087
    • KEP-3085: update kep with implementation details for alpha #4077
  • Code (k/k) update PR(s):
    • Introduce PodHasNetwork condition for pods kubernetes#111358
    • feat: rename PodHasNetwork to PodReadyToStartContainers kubernetes#117702
  • Docs (k/website) update PR(s): PodHasNetwork condition docs website#35704
• Alpha2 (1.28)
  • KEP (k/enhancements) update PR(s):
    • Update KEP with new name: PodReadyToStartContainers condition #3778
  • Code (k/k) update PR(s):
    • feat: rename PodHasNetwork to PodReadyToStartContainers kubernetes#117702
  • Docs (k/website) update PR(s):
    • rename PodHasNetwork to PodReadyToStartContainers as part of rename website#41744
    • rename PodHasNetwork to PodReadyToStartContainers website#40945
• Beta (1.29-1.30)
  • KEP (k/enhancements) update PR(s):
    • KEP-3085: promote to beta in 1.29 #4139
    • [KEP-3085] update kep to say its being worked on in 1.30 #4483
  • Code (k/k) update PR(s):
    • [KEP-3085] Promote PodReadyToStartContainers to beta in 1.29 kubernetes#119659
    • [KEP-3085]: check PodReadyToStartContainers condition after gracefulshutdown kubernetes#121044
    • [KEP - 3085] Add e2e test for PodReadyToStartContainerCondition when config map is created kubernetes#121321
  • Docs (k/website) update(s):
    • update docs to promote PodReadyToStartContainersCondition into beta website#43533
    • Add blog post to reflect state of PodReadyToStartContainersCondition website#43932

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[kannon92]

/sig node

[kannon92]

Moved #3085 to this thread so I can keep it up-to-date with latest changes. It was a bit challenging to keep release team up to date so want to be able to update this.

[kannon92]

@Atharva-Shinde can you please add the same labels as the issue in #3085?

[Atharva-Shinde]

/stage alpha
/milestone v1.28

/label lead-opted-in
for v1.28 as per comment

[Atharva-Shinde]

@kannon92 please link the original issue in this issue description :)

[liggitt]

can this be categorized into a stage in the 1.28 project? the repost of the issue meant it was missing some metadata

[kannon92]

can this be categorized into a stage in the 1.28 project? the repost of the issue meant it was missing some metadata

@Atharva-Shinde are you able to help with this? I see the issue is tracked in the enhancements 1.28 board but I don't see a v1.28 milestone.

[Atharva-Shinde]

can this be categorized into a stage in the 1.28 project?

@liggitt I have updated the stage on the enhancements project board to alpha.

I see the issue is tracked in the enhancements 1.28 board but I don't see a v1.28 milestone.

I'm not sure if I understand you @kannon92, this issue already has a v1.28 milestone tag attached here and on the project board too.

[kannon92]

can this be categorized into a stage in the 1.28 project?

@liggitt I have updated the stage on the enhancements project board to alpha.

I see the issue is tracked in the enhancements 1.28 board but I don't see a v1.28 milestone.

I'm not sure if I understand you @kannon92, this issue already has a v1.28 milestone tag attached here and on the project board too.

I realize I was wrong. I thought I should see a label in the issue with v1.28 but I don't see that.

[npolshakova]

Hello 👋, 1.29 Enhancements Lead here.

If you wish to progress this enhancement in v1.29, please have the SIG lead opt-in your enhancement by adding the lead-opt-in and milestone v1.29 labels before the Production Readiness Review Freeze.

/remove-label lead-opted-in

[SergeyKanzhelev]

/milestone v1.29
/label lead-opted-in

as discussed at sig node meeting this week

[kannon92]

/assign

[sanchita-07]

Hello @kannon92 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage beta for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would need to add/update the following:

• The status should be marked as implementable in the kep.yaml file.
• Ensure that the PR including the production readiness review has been reviewed and merged into k/enhancements.
• KEP readme has up-to-date graduation criteria

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.
Thank you!

[sanchita-07]

Hi @kannon92, checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk for enhancement freeze. It looks like merging of #4139 will address the requirements. Let me know if I missed anything. Thanks!

[sanchita-07]

Hi @kannon92, With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze 🚀.
The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[kannon92]

Can someone update the stage to say beta?

[salehsedghpour]

/remove-label lead-opted-in

[salehsedghpour]

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

[kannon92]

I'm not sure if this needs a milestone. There was one e2e test we needed to get in as part of beta. It went in 1.30 but that was all that was needed for beta.

[salehsedghpour]

@kannon92 , Thanks for clarification. At the moment it's not opted in for 1.30, as it doesn't have lead-opted-in label.

[SergeyKanzhelev]

/stage alpha
/milestone v1.30

[kannon92]

/stage beta

We are in beta currently and there was no revert AFAIK.

[salehsedghpour]

Hello @kannon92 , 1.30 Enhancements team here! Is this enhancement targeting 1.30? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

[mrunalp]

/label lead-opted-in

[mickeyboxell]

Hello @kannon92 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on [02:00 UTC Friday 9th February 2024 / 18:00 PDT Thursday 8th February 2024](https://everytimezone.com/s/1ade3dca):.

This enhancement is targeting for stage beta for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the [latest template](https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template) has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check [here](https://github.com/kubernetes/community/blob/master/sig-architecture/production-readiness.md#submitting-a-kep-for-production-readiness-approval)).

For this KEP, we would need to update the following:

• Make sure to update your kep.yaml with the latest-milestone and milestone of `v1.30'

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[kannon92]

IMO not sure its really worth bumping the latest-milestone as all we needed to do in this one was merge a e2e test.

With that being said, I created #4483 to address that last point if its needed.

[kannon92]

#4483 was merged so I think this should be no longer at risk.

[mickeyboxell]

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

[Checksumz]

Hi @kannon92 ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

[kannon92]

Thank you! I won't be doing a feature blog for this enhancement.

[Checksumz]

Thanks for your response @kannon92

[drewhagen]

Hello @kannon92 👋, 1.30 Docs Lead here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[charles-chenzz]

There's won't be any blogs post for this KEP on 1.30 AFAIK

[drewhagen]

What about new docs or modifications to existing docs?

[kannon92]

We are only in this release to add a e2e test. We updated docs in the last release.

[mickeyboxell]

Hey again @kannon92 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

With all the implementation (code related) PRs merged as per the issue description:

• [KEP - 3085] Add e2e test for PodReadyToStartContainerCondition when config map is created kubernetes#121321

This enhancement is now marked as tracked for code freeze for the v1.30 Code Freeze!

The last thing to do is to update the status field in the kep.yaml file to implemented when the code PRs are merged and the feature gates are removed.

[sreeram-venkitesh]

Hi @kannon92 👋, 1.31 Enhancements Lead here.

If you wish to progress this enhancement in v1.31, please have the SIG lead opt-in your enhancement by adding the lead-opted-in label and set the milestone to v1.31 before the Production Readiness Review Freeze.

/remove-label lead-opted-in