-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[occm] The nodeSelector key is not empty in the helm chart in release v1.29.0 #2550
Comments
This got introduced in #2346. @wwentland, would you care to comment here? As a workaround, would just setting |
@dulek The workaround doesn't help if I need to add my own For example, I want to use <...>
spec:
nodeSelector:
my.corp.selector/front: "true"
node-role.kubernetes.io/control-plane: ""
<...> |
I was able to do what you need with this values.yaml:
This gets my
Based on Helm Docs. Can I close this issue now? |
@dulek thx. I didn't know about this feature of helm. |
I think so. I believe @wwentland motivation to change this was to follow what AWS provider does and it makes sense to me: https://github.com/kubernetes/cloud-provider-aws/blob/master/charts/aws-cloud-controller-manager/values.yaml#L14-L16. Your use case is still valid, but since we've figured out how to override the default, I think we should keep the current 1.29 behavior. |
I admit I don't fully understand what the specific AWS implementation has to do with it. |
But in the end AWS and OpenStack K8s clusters shouldn't be too different. The idea is that cloud-provider-openstack being part of the control plane, lands on the control plane nodes. This should basically be true for any platform and any cloud-provider.
Sure thing, docs are always welcome! Can you prepare the PR? I'll be happy to review and approve it. |
**This is a BUG REPORT **:
/kind bug
What happened:
Since the release v1.29.0, the nodeSelector key in the file values.yaml of the helm chart is no longer empty and therefore requires positioning the following label
node-role.kubernetes.io/controlplane: ""
on the workers where the daemonSet must be deployed.What you expected to happen:
The nodeSelector key in the file values.yaml of the helm chart should be empty.
nodeSelector: {}
How to reproduce it:
Install occm v1.29.0 with the helm chart.
Environment:
Let me know if you need a PR.
Regards.
The text was updated successfully, but these errors were encountered: