[cinder-csi-plugin] Add metadata in creation of volume

[Kortekaasy]

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:
My cloud provider uses the metadata field in the volume creation API call to enable e.g. encrypted volumes. Looking at the documentation & source code, it doesn't look like it's possible at this moment to such metadata to a PVC. If this is really not possible at the moment, could anyone give me some pointers on where to start to add such functionality?

[kayrus]

See also #2327.

[jichenjc]

@kayrus I assume you are talking about #2327 (comment) ? want to split the design of LB and CSI into different issue and can cross link

https://github.com/kubernetes/cloud-provider-openstack/blob/master/pkg/csi/cinder/controllerserver.go#L107
is something we can refer to

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[Kortekaasy]

I see that this is somewhat related to #2327 (comment), but I also see development has stagnated there. If I were to implement adding metadata to volume creation, could anyone give me some pointers?

[Kortekaasy]

/remove-lifecycle rotten

[dulek]

I see that this is somewhat related to #2327 (comment), but I also see development has stagnated there. If I were to implement adding metadata to volume creation, could anyone give me some pointers?

At a glance I'd say it's almost implemented at [1]. What you would need to add is to read some more annotations at [2] (and maybe [3], but ephemeral volumes might not need that?) and pass them to properties variable. On the implementation PR we'll probably spend some time figuring out how to properly name the annotation itself.

[1]

cloud-provider-openstack/pkg/csi/cinder/openstack/openstack_volumes.go

Lines 66 to 68 in e87f506

	if tags != nil {
	opts.Metadata = tags
	}

[2]

cloud-provider-openstack/pkg/csi/cinder/controllerserver.go

Lines 105 to 112 in e87f506

	// Volume Create
	properties := map[string]string{cinderCSIClusterIDKey: cs.Driver.cluster}
	//Tag volume with metadata if present: https://github.com/kubernetes-csi/external-provisioner/pull/399
	for _, mKey := range []string{"csi.storage.k8s.io/pvc/name", "csi.storage.k8s.io/pvc/namespace", "csi.storage.k8s.io/pv/name"} {
	if v, ok := req.Parameters[mKey]; ok {
	properties[mKey] = v
	}
	}

[3]

cloud-provider-openstack/pkg/csi/cinder/nodeserver.go

Line 130 in e87f506

properties := map[string]string{"cinder.csi.openstack.org/cluster": ns.Driver.cluster}