Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[occm] improve LB logic maintainability #2377

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

[occm] improve LB logic maintainability #2377

wants to merge 6 commits into from
+954 −821

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Sep 28, 2023

What this PR does / why we need it:

This PR improves the loadbalancer code readability and maintainability.

Which issue this PR fixes(if applicable):

fixes #2374

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 28, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 28, 2023
@kayrus kayrus mentioned this pull request Sep 28, 2023
Merged
@dulek
Copy link
Contributor

dulek commented Oct 4, 2023

Oh my. Please put updating the license header into a separate PR, this one will be hard enough to review already.

@pierreprinetti
Copy link
Member

@kayrus
WRT changing the year of publication in the copyright header: what is your reasoning behind that?

@kayrus
Copy link
Contributor Author

kayrus commented Oct 11, 2023 •
edited

WRT changing the year of publication in the copyright header: what is your reasoning behind that?

@pierreprinetti My goal was to split loadbalancer.go into multiple files, and I noticed that I also need to put a new license header there with a new 2023 year (or can I just use the same header from the original loadbalancers.go?). In addition I looked into other places, where the headers are used. Nevertheless, this PR is a WIP. I'll focus on it a bit later and will move out the license update from it.

@kayrus
Copy link
Contributor Author

kayrus commented Oct 11, 2023

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 11, 2023
@pierreprinetti
Copy link
Member

I noticed that I also need to put a new license header there with a new 2023 year

Why?
Unless I'm mistaken, the copyright year means "year of first publication". Even if the content is moved around, and even if it is changed (or added to), I believe that the year of first publication has no reason to change.

That being said, the copyright year is not very interesting from a legal perspective, because the date of publication is also kept by Github. So you could probably put bananas in it.

@kayrus
Copy link
Contributor Author

kayrus commented Oct 19, 2023

Why?

@pierreprinetti I've seen such updates in other opensource projects. If you think that this doesn't make sense, then I'll put this year to the new files and skip others.

@kayrus kayrus mentioned this pull request Oct 19, 2023
Open
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2023
@kayrus kayrus mentioned this pull request Nov 16, 2023
Closed
This was referenced Dec 12, 2023
Merged
Closed
Closed
Closed
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2023
@kayrus
Copy link
Contributor Author

kayrus commented Dec 12, 2023

/test openstack-cloud-controller-manager-e2e-test

@kayrus
Copy link
Contributor Author

kayrus commented Dec 12, 2023

/test openstack-cloud-controller-manager-e2e-test

1 similar comment
@kayrus
Copy link
Contributor Author

kayrus commented Dec 12, 2023

/test openstack-cloud-controller-manager-e2e-test

@k8s-ci-robot
Copy link
Contributor

@kayrus: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
openstack-cloud-controller-manager-e2e-test ca6ad90 link true /test openstack-cloud-controller-manager-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kayrus. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 13, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link
Contributor

dulek commented Jan 10, 2024

@kayrus: Hi! Do we have another attempt at merging this? I believe it's a very good idea to split this code into separate files.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 9, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[occm] improve LB logic maintainability
5 participants
@kayrus @k8s-ci-robot @dulek @pierreprinetti @k8s-triage-robot