Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint for yaml_test.go #63

Merged
merged 1 commit into from Sep 22, 2021
Merged

Fix lint for yaml_test.go #63

merged 1 commit into from Sep 22, 2021

Conversation

akram
Copy link

@akram akram commented Sep 22, 2021

Fix lint for yaml_test.go

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 22, 2021
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 22, 2021
@akram
Copy link
Author

akram commented Sep 22, 2021

/assign liggitt

@liggitt
Copy link

liggitt commented Sep 22, 2021

/lgtm
/approve

@akram akram mentioned this pull request Sep 22, 2021
Merged
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2021
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akram, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9535b3b into kubernetes-sigs:master Sep 22, 2021
@maver1ck
Copy link

maver1ck commented Sep 23, 2021 •
edited

@liggitt
Any chance to new release 1.2.1 of kubernetes/yaml ?
Then we can upgrade it in dependent projects

@liggitt
Copy link

liggitt commented Sep 23, 2021

published https://github.com/kubernetes-sigs/yaml/releases/tag/v1.3.0

@akram
Copy link
Author

akram commented Sep 23, 2021

awesome thanks @liggitt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akram @liggitt @k8s-ci-robot @maver1ck