Bump gopkg.in/yaml.v2 to v2.4.0: fixes inconsistent long lines wrapping

[akram]

Fixes #54 which is required to fix other issues like:

• newline discrepancy in CRDs generated by controller-gen controller-tools#514
• Customize yaml.Marshal wrap behavior go-yaml/yaml#387
• Line breaks on long strings with spaces kustomize#947
• controller-gen use of line breaks varies minimally on operator system shipwright-io/build#832

I have added a test case and tested it with version 2.2.8 of gopkg.in which breaks with:

--- FAIL: TestJSONToYAML (0.00s)
    yaml_test.go:382: converting {"t":"a"}
    yaml_test.go:382: converting {"t":null}
    yaml_test.go:382: converting {"t":"this is very long line with spaces and it must be longer than 80 so we will repeat that it must be longer that 80"}
    yaml_test.go:390: Failed to convert JSON to YAML, input: `{"t":"this is very long line with spaces and it must be longer than 80 so we will repeat that it must be longer that 80"}`, expected `t: this is very long line with spaces and it must be longer than 80 so we will repeat that it must be longer that 80
        `, got `t: this is very long line with spaces and it must be longer than 80 so we will repeat
          that it must be longer that 80
        `
FAIL

using v2.3.0 works well:

=== RUN   TestJSONToYAML
    yaml_test.go:382: converting {"t":"a"}
    yaml_test.go:382: converting {"t":null}
    yaml_test.go:382: converting {"t":"this is very long line with spaces and it must be longer than 80 so we will repeat that it must be longer that 80"}
--- PASS: TestJSONToYAML (0.00s)

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @akram!

It looks like this is your first PR to kubernetes-sigs/yaml 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/yaml has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[akram]

/assign @liggitt

[liggitt]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akram, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[maver1ck]

I think this line break lint tests.
https://github.com/kubernetes-sigs/yaml/runs/3676349895

[liggitt]

@akram can you format the files in a follow up PR?

[akram]

sure @liggitt

[akram]

here it is #63

[karlschriek]

Is kubernetes-sigs/kustomize#947 supposed to be fixed by this, or something additional still needed?

[karlschriek]

Nope, this in itself doesn't fix kubernetes-sigs/kustomize#947. I just rebuilt 4.3.0 with sigs.k8s.io/yaml bumped from 1.2.0 to 1.3.0 and still get the same result.