Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI tests for ARM64 #44

Merged
merged 1 commit into from Jan 28, 2021
Merged

Add CI tests for ARM64 #44

merged 1 commit into from Jan 28, 2021

Conversation

hakman
Copy link
Member

@hakman hakman commented Nov 13, 2020 •
edited

Ref: #34 (comment)

Skipping Go 1.14 because it was never used in any k8s release.
The -race flag is not supported on linux/arm.
Tests should fail until #42 is merged.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2020
@hakman
Copy link
Member Author

hakman commented Nov 13, 2020

/cc @neolit123 @afbjorklund @zhsj

@k8s-ci-robot
Copy link

@hakman: GitHub didn't allow me to request PR reviews from the following users: afbjorklund, zhsj.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @neolit123 @afbjorklund @zhsj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2020
@hakman hakman force-pushed the travisci-arm64 branch 6 times, most recently from 8b32345 to 932e0c7 Compare November 13, 2020 10:02
neolit123
neolit123 reviewed Nov 13, 2020
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020
@hakman
Copy link
Member Author

hakman commented Nov 13, 2020

Thanks @neolit123. Will wait for #42 to merge and rebase.

@hakman
Copy link
Member Author

hakman commented Nov 17, 2020

/assign @liggitt

liggitt
liggitt reviewed Nov 17, 2020
View reviewed changes
.travis.yml Outdated
script:
- diff -u <(echo -n) <(gofmt -d *.go)
- diff -u <(echo -n) <(golint $(go list -e ./...) | grep -v YAMLToJSON)
- GO111MODULE=on go vet .
- GO111MODULE=on go test -v -race ./...
- if [[ $TRAVIS_CPU_ARCH == "arm64" ]]; then
GOARCH=arm GOARM=7 GO111MODULE=on go test -v ./...;
Copy link

@liggitt liggitt Nov 17, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you describe what this is doing? I'm surprised setting GOARCH explicitly is required

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is building and testing the 32-bit binary (armv7), so it's like a two-for-one (arm64+arm32)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One idea in the original issue was to use the CI setup to run the ARM v7 tests also, as it should be compatible with both v7 and v8.

In case the TravisCI CPU is ARM64, an ARM v7 test is also run, but without -race, which is not supported.

@hakman hakman requested a review from liggitt November 21, 2020 22:50
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2021
@hakman hakman force-pushed the travisci-arm64 branch 2 times, most recently from 9e95499 to 52890f4 Compare January 28, 2021 07:40
@hakman hakman force-pushed the travisci-arm64 branch 3 times, most recently from 02d0e46 to 81e230f Compare January 28, 2021 07:49
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 28, 2021
@hakman hakman force-pushed the travisci-arm64 branch 2 times, most recently from 840c2b1 to 38c293b Compare January 28, 2021 07:56
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 28, 2021
@hakman
Copy link
Member Author

hakman commented Jan 28, 2021

@neolit123 @liggitt as TravisCI was replaced by GitHub actions, I updated the PR to only test ARM64, which is missing from GitHub actions for now (should be available sometime in Q1).

@hakman hakman requested a review from neolit123 January 28, 2021 08:01
@dims
Copy link
Member

dims commented Jan 28, 2021

thanks @hakman

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2021
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 11e43d4 into kubernetes-sigs:master Jan 28, 2021
@hakman hakman deleted the travisci-arm64 branch January 28, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund afbjorklund left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

@sttts sttts Awaiting requested review from sttts

@liggitt liggitt Awaiting requested review from liggitt

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@dims dims

@neolit123 neolit123

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hakman @k8s-ci-robot @dims @neolit123 @liggitt @afbjorklund