Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should this library move to yaml.v3 #18

Open
errordeveloper opened this issue Apr 26, 2019 · 6 comments
Open

Should this library move to yaml.v3 #18

errordeveloper opened this issue Apr 26, 2019 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@errordeveloper
Copy link

gopkg.in/go-yaml.v3 is already available, should we upgrade to it?
@dims
Copy link
Member

dims commented Apr 26, 2019

yes, go for it! note that we would have to trial run changes using a WIP PR in k/k

@neolit123
Copy link
Member

/kind feature
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Apr 26, 2019
@errordeveloper errordeveloper mentioned this issue Apr 26, 2019
Closed
@laverya laverya mentioned this issue Jul 10, 2019
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 25, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 24, 2019
@neolit123
Copy link
Member

neolit123 commented Aug 25, 2019 •
edited

the API calls in v3 changed, so if we decide to do this we might have to fork.

see the discussion in this PR:
#26

@neolit123
Copy link
Member

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 25, 2019
@xmudrii xmudrii mentioned this issue Sep 30, 2019
Closed
@clarketm clarketm mentioned this issue Nov 8, 2019
Merged
@roycaihw roycaihw mentioned this issue Jun 1, 2021
Closed
@monopole monopole mentioned this issue Jun 9, 2021
Closed
@KnVerey KnVerey mentioned this issue Jul 6, 2021
Merged
@inteon inteon mentioned this issue Sep 11, 2021
Closed
@tomasaschan tomasaschan mentioned this issue Nov 15, 2021
Closed
@achrefbensaad achrefbensaad mentioned this issue Jul 18, 2022
Open
@rm3l rm3l mentioned this issue Aug 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade yaml.v2 to yaml.v3, improve testing and bugfixes amurant/yaml
5 participants
@dims @errordeveloper @neolit123 @k8s-ci-robot @fejta-bot