Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should this library use json-iterator? #17

Open
errordeveloper opened this issue Apr 26, 2019 · 9 comments
Open

Should this library use json-iterator? #17

errordeveloper opened this issue Apr 26, 2019 · 9 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@errordeveloper
Copy link

Kubernetes uses github.com/json-iterator/go instead of encoding/json, should this library switch also?

@dims
Copy link
Member

dims commented Apr 26, 2019

sure!

@neolit123
Copy link
Member

/assign
although need to find bandwidth.
i'm yet to check #15
but i suspect discrepancy between the current backends: yaml2 vs encoding/json.

json-iter does support case sensitive JSON.

@neolit123
Copy link
Member

/kind feature
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Apr 26, 2019
@errordeveloper
Copy link
Author

errordeveloper commented Apr 26, 2019

json-iter does support case sensitive JSON.

You mean it can detect unknown keys in case-sensitive manner?

@neolit123
Copy link
Member

neolit123 commented Apr 26, 2019

You mean it can detect unknown keys in case-sensitive manner?

yes. i have a PR in the works to enable json-iter.
whether it makes it in is another question as it requires a minor breaking change.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 25, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 24, 2019
@neolit123
Copy link
Member

neolit123 commented Aug 25, 2019

initial reaction was that there is no good justification for this change:
#19
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 25, 2019
@neolit123
Copy link
Member

Looks like there is desire to switch k/k away from json iter.

kubernetes/kubernetes#105030

It suggests using a fork of stdlib, that supports the missing valudation features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants