Revert backwards incompatible changes #224
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
schema/elements.go
Outdated
| lockOnce sync.Once | ||
| // Lock which protects writes to resolvedTypes. Used as pointer so that | ||
| // schema may be used as a value type | ||
| lock *sync.Mutex |
There was a problem hiding this comment.
Do we need all these locks here? Can we make the lock by value since we're not supposed to copy a schema?
There was a problem hiding this comment.
yeah there were no unsafe schema usages in the ptr semantics refactor nor in k8s/openapi usage
There was a problem hiding this comment.
can remove the once. just need the lock
|
/hold tentative lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
OK I've tried to fix the tags, done this:
|
Can we live with that? Everything still passes, but at least we don't have to bump the major, so any backport/cherry-pick will be much easier to sell.