Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the dockerfile gen command #4216

Merged
merged 1 commit into from Sep 29, 2021

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Sep 29, 2021

  • Split go mod download as a separate step to avoid download the go modules every single time when the users make non-dependency changes to the source code.
  • Using ENTRYPOINT instead of CMD, so the users doesn't need to know what command they need to run (e.g. If the command is not called function, the user can still run docker run my-image-name --help)
  • Dropped -tags netgo, since it's not necessary when we already set CGO_ENABLED=0.
  • Added -s in -ldflags to disable symbol table and it further reduces the image size.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 29, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2021
@mengqiy
Copy link
Member Author

mengqiy commented Sep 29, 2021

/cc @KnVerey

@KnVerey
Copy link
Contributor

KnVerey commented Sep 29, 2021

Makes sense, thanks!
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 68790e0 into kubernetes-sigs:master Sep 29, 2021
@mengqiy mengqiy deleted the updatedockerfilegen branch September 29, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants