Strconv.atoi invalid syntax #816 not resolved by #832

[donbowman]

In #816 I gave an example of a type of syntax error in the input yaml that lead rise to a non-useful error. In this case, it did not indicate the file or line or object or type of error, it just said:

Error: strconv.Atoi: parsing "": invalid syntax

#832 was created, ostensibly to address this.
However, it does exactly the same thing with input file as given in #816 .

I fetched from master, verified commit 78cbff1 was present, ran go build, and then ./kustomize build /tmp/x

$ ./kustomize build /tmp/x
Error: strconv.Atoi: parsing "": invalid syntax

The syntax error is the missing - at the end of the op:

$ cat /tmp/x/default-issuer.yaml 
---
- op: add
  path: /spec/template/spec/containers/0/args/
  value: --default-issuer-kind=ClusterIssuer 
- op: add
  path: /spec/template/spec/containers/0/args/
  value: --default-issuer-name=letsencrypt

So I don't think this PR addresses the issue, the behaviour is unchanged.

My expectation is that I get file:line information, something useful I can go and find my syntax error. Its too complex to binary search down otherwise.

[Liujingfang1]

The line number if not available for Kustomize. I opened an issue in the library for json-patch. evanphx/json-patch#75

[donbowman]

even so...
there's no change in the output w/ the PR. So its not clear how the PR solves the original issue?
can it at least talk about the object type its processing?

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[donbowman]

/remove-lifecycle rotten

the upstream code has had some improvement evanphx/json-patch#75 so changing the dependency would help.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.