Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patches does not update metadata.name properly #5662

Open
Destorntw opened this issue Apr 16, 2024 · 1 comment
Open

patches does not update metadata.name properly #5662

Destorntw opened this issue Apr 16, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@Destorntw
Copy link

What happened?

when using the following structure:
|-Base
| |-----CRB
| |
| | clusterrolebinding.yaml
|-Overlays
| |-----CRB
| |
| | crb-patches.yaml

and in the patches file I specify another name than the metadata.name in the patches file the name doesn't change.

What did you expect to happen?

When building the file in "dry run" or when applying the built manifest with the customization patches to be applied with the new name that what modified from the patches file.

How can we reproduce it (as minimally and precisely as possible)?

# kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- crb.yaml
# crb.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  name: cluster-users-n
roleRef:
#data-yyyyyy

Expected output

# crb-patches.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  name: name-patched
roleRef:
#data-xxxxxxx

Actual output

# crb.yaml
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  name: cluster-users-n
roleRef:
#data-xxxxxxx

Kustomize version

5.4.1

Operating system

Windows

@Destorntw Destorntw added the kind/bug Categorizes issue or PR as related to a bug. label Apr 16, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants