Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kustomize example in README uses deprecated commonLabels #5653

Open
paololazzari opened this issue Apr 10, 2024 · 5 comments
Open

kustomize example in README uses deprecated commonLabels #5653

paololazzari opened this issue Apr 10, 2024 · 5 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@paololazzari
Copy link

paololazzari commented Apr 10, 2024

What happened?

When running the example in the README:

# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

Kustomize version

v5.4.1

@paololazzari paololazzari added the kind/bug Categorizes issue or PR as related to a bug. label Apr 10, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 10, 2024
@varshaprasad96
Copy link
Member

@paololazzari Thanks for brining up this issue. The docs do seem to be outdated: https://kubernetes.io/docs/tasks/manage-kubernetes-objects/kustomization/.

Would you be open to submitting a PR to fix this in the docs website. Any help from the community is appreciated. Thanks!

@varshaprasad96 varshaprasad96 added kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 10, 2024
@varshaprasad96
Copy link
Member

cc: @ncapps

@ah8ad3
Copy link

ah8ad3 commented Apr 11, 2024

Maybe i can help with this issue.

@ah8ad3
Copy link

ah8ad3 commented Apr 15, 2024

The docs do seem to be outdated: https://kubernetes.io/docs/tasks/manage-kubernetes-objects/kustomization/.

@varshaprasad96 The actual version of Kustomize inside kubectl is old i don't think we should update this until the version is bumped up.
Instead i think we should update this site, https://kubectl.docs.kubernetes.io/references/kustomize/
Also the examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants