Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement localizeFile() skeleton for patches #4865

Merged
merged 6 commits into from Nov 16, 2022
Merged

Implement localizeFile() skeleton for patches #4865

merged 6 commits into from Nov 16, 2022

Conversation

annasong20
Copy link
Contributor

This PR introduces the skeleton for localizeFile() and begins to test it on the patches, patchesJson6902 fields.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 11, 2022
@k8s-ci-robot
Copy link
Contributor

@annasong20: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@annasong20
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 11, 2022
yuwenma
yuwenma approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments. Looks good on my side, defer to Natasha to approve.

api/internal/localizer/localizer.go Outdated Show resolved Hide resolved
api/internal/localizer/localizer.go Outdated Show resolved Hide resolved
api/internal/localizer/localizer.go Outdated Show resolved Hide resolved
api/internal/localizer/localizer.go Outdated Show resolved Hide resolved
api/internal/localizer/util.go Outdated Show resolved Hide resolved
@yuwenma
Copy link
Contributor

yuwenma commented Nov 11, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 11, 2022
@annasong20 annasong20 mentioned this pull request Nov 14, 2022
Merged
natasha41575
natasha41575 reviewed Nov 15, 2022
View reviewed changes
api/internal/localizer/localizer.go Show resolved Hide resolved
api/internal/localizer/localizer.go Outdated Show resolved Hide resolved
api/internal/localizer/localizer.go Outdated Show resolved Hide resolved
@yuwenma
Copy link
Contributor

yuwenma commented Nov 15, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2022
@natasha41575
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annasong20, natasha41575, yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 16, 2022
@natasha41575 natasha41575 mentioned this pull request Nov 16, 2022
Merged
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2022
@natasha41575
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 314b8fb into kubernetes-sigs:master Nov 16, 2022
@annasong20 annasong20 deleted the localize-patches branch November 16, 2022 21:43
elisshafer pushed a commit to elisshafer/kustomize that referenced this pull request Dec 8, 2022
@annasong20 @elisshafer
Implement localizeFile() skeleton for patches (kubernetes-sigs#4865)
77362fb 
* Implement localizeFile()

* Fix lint

* Address code review feedback

* Remove unnecessary String(), Error() with string formatters
* Remove processing of un-implemented methods
* Improve readability

* Remove unimplemented addLocalizeDir, hitsLocalizeDir

* Improve documentation

* Remove deprecated patchesJson6902 logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenma yuwenma yuwenma approved these changes

@natasha41575 natasha41575 natasha41575 left review comments

Assignees

@yuwenma yuwenma

@natasha41575 natasha41575

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@annasong20 @k8s-ci-robot @yuwenma @natasha41575