Improve localizer readability

[annasong20]

This PR aims to improve the readability of code under api/internal/localizer. Specifically, it addresses readability-related code review feedback from #4797.

[k8s-ci-robot]

@annasong20: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[annasong20]

/label tide/merge-method-squash

[yuwenma]

I think we want to find a better name to replace Args and raw...

• args is normally used on string slice variables which is used as CLI argument.
  e.g. kustomize build <ARGS> see code
• raw should be either 1. more specific 2. more concise (e.g. rawScope -> scope), defer to whether the variables are used in the main logic (meaning matters) or in a helper methods (concise wins). Shall we change establishScope to something like GetEffectiveScope or EffectiveScope like [effectiveNamespace](https://github.com/kubernetes-sigs/kustomize/blob/fcfd30ca18bf5d533e1c1b6e94bb47ffd2c24f18/kyaml/resid/resid.go#L149)
  So the code will be

// Before
scope, err := establishScope(rawScope, rawTarget, ldr, fSys)
// After
effectiveScope, err := GetEffectiveScope(scope, target, ldr, fSys)

[annasong20]

I think we want to find a better name to replace Args and raw...

• args is normally used on string slice variables which is used as CLI argument.
  e.g. kustomize build <ARGS> see code
• raw should be either 1. more specific 2. more concise (e.g. rawScope -> scope), defer to whether the variables are used in the main logic (meaning matters) or in a helper methods (concise wins). Shall we change establishScope to something like GetEffectiveScope or EffectiveScope like [effectiveNamespace](https://github.com/kubernetes-sigs/kustomize/blob/fcfd30ca18bf5d533e1c1b6e94bb47ffd2c24f18/kyaml/resid/resid.go#L149)
  So the code will be

// Before
scope, err := establishScope(rawScope, rawTarget, ldr, fSys)
// After
effectiveScope, err := GetEffectiveScope(scope, target, ldr, fSys)

1. Sure! I can change raw as you've dictated here.
2. Yeah, I wanted Args to represent the cleaned, validated CLI arguments for localize. Unfortunately, it's not a []string. I've been thinking about alternatives. How do you like Spec or Constants?

[yuwenma]

I think we want to find a better name to replace Args and raw...

• args is normally used on string slice variables which is used as CLI argument.
  e.g. kustomize build <ARGS> see code
• raw should be either 1. more specific 2. more concise (e.g. rawScope -> scope), defer to whether the variables are used in the main logic (meaning matters) or in a helper methods (concise wins). Shall we change establishScope to something like GetEffectiveScope or EffectiveScope like [effectiveNamespace](https://github.com/kubernetes-sigs/kustomize/blob/fcfd30ca18bf5d533e1c1b6e94bb47ffd2c24f18/kyaml/resid/resid.go#L149)
  So the code will be

// Before
scope, err := establishScope(rawScope, rawTarget, ldr, fSys)
// After
effectiveScope, err := GetEffectiveScope(scope, target, ldr, fSys)

1. Sure! I can change raw as you've dictated here.
2. Yeah, I wanted Args to represent the cleaned, validated CLI arguments for localize. Unfortunately, it's not a []string. I've been thinking about alternatives. How do you like Spec or Constants?

ah, I see. Args makes sense.

[yuwenma]

/lgtm

[natasha41575]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annasong20, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [natasha41575]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment