Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kyaml's dependency swag to v0.22.3 #4830

Merged
merged 5 commits into from Nov 4, 2022

Conversation

sunmin89
Copy link
Contributor

kyaml now depends on swag v0.19.14 which itself depends on https://github.com/niemeyer/pretty, this pretty package is a fork

of https://github.com/kr/pretty, the previous pretty is out of date,while the latter is maintained well,

swag v0.22.3 has already updated its dependency to kr's, I think it's necessary to update kyaml's too

thanks.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 12, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 12, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @summer-dev!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 12, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @summer-dev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2022
@k8s-ci-robot
Copy link
Contributor

@summer-dev: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2022
@natasha41575
Copy link
Contributor

Please sign the CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 17, 2022
@sunmin89
Copy link
Contributor Author

Please sign the CLA

Done,thanks for your remind :)

@sunmin89
Copy link
Contributor Author

Thanks for your review @mengqiy @phanimarupaka

@natasha41575
Copy link
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 21, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2022
@natasha41575
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2022
@sunmin89
Copy link
Contributor Author

@natasha41575

dear natasha41575 :

i'm confused about the failure reason of this sute : test-unit-non-plugin, it seems that some missed files are needed during testing.

image

i wonder where i can get these missed files? how can I solve this problem,

thanks

@koba1t
Copy link
Member

koba1t commented Nov 1, 2022

Hi @summer-dev
I think that CI failure is caused by changing environment on GitHub Actions and that was fixed at #4844.
So, Could you try to rebase master?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@sunmin89
Copy link
Contributor Author

sunmin89 commented Nov 2, 2022

i wish another LGTM gift :)

@koba1t
Copy link
Member

koba1t commented Nov 2, 2022

Thanks, @summer-dev!
Can I add a nit suggestion?
Could you update libs for other places using a function of go workspace mode?
That will work by typing the command to work sync!

/assign koba1t

@sunmin89
Copy link
Contributor Author

sunmin89 commented Nov 2, 2022

Hi, after executing

go work sync

About 90 files are modified, should I commit theses changes to my forked repo? and then waiting to be merged.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natasha41575, summer-dev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 2, 2022
@koba1t
Copy link
Member

koba1t commented Nov 3, 2022

Hi @summer-dev

About 90 files are modified, should I commit theses changes to my forked repo?

Thanks! Please commit these files!
So, I checked for tests on make test-unit-non-plugin and found one failed.
I think this is caused by the docker build error on cmd/config/internal/commands/e2e/e2econtainerconfig/ dir.

I'm sorry for the inconvenience. Please exec go mod tidy on cmd/config/internal/commands/e2e/e2econtainerconfig/ dir?

@koba1t
Copy link
Member

koba1t commented Nov 4, 2022

/lgtm

Hi @natasha41575
Could you recheck it and run GitHub actions?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit 14f3cea into kubernetes-sigs:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants