Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint Errors on Github repo #4760

Closed
laxmikantbpandhare opened this issue Aug 12, 2022 · 2 comments · Fixed by #4754
Closed

Lint Errors on Github repo #4760

laxmikantbpandhare opened this issue Aug 12, 2022 · 2 comments · Fixed by #4754
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@laxmikantbpandhare
Copy link
Member

Getting lint errors after submitting PR on kustomize as shown below

Describe the bug

Error: api/krusty/openapitests/openapicustomschema_test.go:10:2: SA1019: package io/ioutil is deprecated: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
	"io/ioutil"
	^
make[1]: *** [../Makefile-modules.mk:17: lint] Error 1
make[1]: Leaving directory '/home/runner/work/kustomize/kustomize/api'
make: *** [Makefile:126: lint] Error 2

Files that can reproduce the issue

All the test files that have io/ioutil import.

Expected output

lint errors will not be shown

Actual output

Link Check will run successfully

Additional context

We can replace io/ioutil with package io or oc in order to skip link errors. These new packages provides same functionality as of io/ioutil

@laxmikantbpandhare laxmikantbpandhare added the kind/bug Categorizes issue or PR as related to a bug. label Aug 12, 2022
@k8s-ci-robot
Copy link
Contributor

@laxmikantbpandhare: This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 12, 2022
@laxmikantbpandhare
Copy link
Member Author

Looks like this issue is already taken care by this PR #4754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants