Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve invalid node kind errors #4727

Merged
merged 3 commits into from Aug 25, 2022

Conversation

KnVerey
Copy link
Contributor

@KnVerey KnVerey commented Jul 28, 2022

Also enhance this kind of error specifically in the namespace transformer, explaining to the user that it is probably a field spec issue. Also remove ignored field specs from that transformer's defaults, including two that are invalid in a way that would produce this message (but continuing to ignore the valid path).

@annasong20 was correct that it is the kyaml error package that is not working with errors.Is and errors.As. That is because it uses a very old version of its go-errors dependency, that didn't have go-1.13 style support. I think we are the reason k/k has this dep, and the diff to update all the way to latest is quite small in any case: go-errors/errors@v1.0.1...v1.4.2.

/cc @natasha41575

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2022
@k8s-ci-robot
Copy link
Contributor

@KnVerey: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 28, 2022
@KnVerey
Copy link
Contributor Author

KnVerey commented Jul 28, 2022

/hold for rebase on #4704 when it merges (unless we change our mind about the order)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 28, 2022
@netlify
Copy link

netlify bot commented Jul 28, 2022

Deploy Preview for kubernetes-sigs-kustomize canceled.

Name Link
🔨 Latest commit ffdb1ed
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kustomize/deploys/62e2deaa47440b000911e3a1

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2022
@KnVerey
Copy link
Contributor Author

KnVerey commented Jul 28, 2022

This has been rebased, but it might be good to hold until after the next release in case the dep upgrade unexpectedly is in fact an issue for kubectl.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 10, 2022
@KnVerey
Copy link
Contributor Author

KnVerey commented Aug 10, 2022

/unhold

This is ready for a look

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2022
@natasha41575
Copy link
Contributor

Ah sorry I missed this PR

/lgtm
/approve

I can retag if you need to rebase

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KnVerey,natasha41575]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2022
@KnVerey
Copy link
Contributor Author

KnVerey commented Aug 16, 2022

@natasha41575 I rebased and added two new commits: one making an improvement I couldn't do in #4754 because of the go-errors version, and another committing go.sum changes. PTAL.

@natasha41575
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2e2674f into kubernetes-sigs:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants