Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch github.com/xlab/treeprint to release tag : v1.1.0 #4675

Merged
merged 2 commits into from Jun 10, 2022
Merged

Switch github.com/xlab/treeprint to release tag : v1.1.0 #4675

merged 2 commits into from Jun 10, 2022

Conversation

dims
Copy link
Member

@dims dims commented Jun 10, 2022

Avoid using a random tag of a dependency. Switching to v1.1.0 instead.

Signed-off-by: Davanum Srinivas davanum@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 10, 2022
@natasha41575
Copy link
Contributor

natasha41575 commented Jun 10, 2022 •
edited

Looks like you'll need to do some go mod tidy or go mod downloads in cmd/pluginator. There may be some other directories that need it too, unfortunately we don't have a good automatic way of doing this, so we usually just wait to see what the CI says

@dims dims force-pushed the switch-github.com/xlab/treeprint-to-release-tag-v1.1.0 branch from be33e37 to 06c1fd8 Compare June 10, 2022 20:21
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 10, 2022
@dims
Switch github.com/xlab/treeprint to release tag : v1.1.0
784a5d5 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the switch-github.com/xlab/treeprint-to-release-tag-v1.1.0 branch from 06c1fd8 to 784a5d5 Compare June 10, 2022 20:25
@dims
fix test to reflect changes in the dependency
8628fd1 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot
Copy link
Contributor

@dims: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@natasha41575
Copy link
Contributor

/lgtm
/approve

@natasha41575 natasha41575 added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7e0fd02 into kubernetes-sigs:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengqiy mengqiy Awaiting requested review from mengqiy

@phanimarupaka phanimarupaka Awaiting requested review from phanimarupaka

Assignees

@natasha41575 natasha41575

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dims @natasha41575 @k8s-ci-robot