Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fn framework: bugfix for schema providers + configurable template extensions #4629

Merged
merged 3 commits into from May 10, 2022

Conversation

KnVerey
Copy link
Contributor

@KnVerey KnVerey commented May 9, 2022

A small enhancement and a bug fix for the functions framework, in separate commits:

  • Configurable extensions for template parser: the default extension we expect is .template.yaml, which is non-standard. This allows one or more other extensions to be explicitly targeted.
  • Regression test and fix for APIs that satisfy ValidationSchemaProvider but not Validator: Before this fix, if you implemented ValidationSchemaProvider but not Validator, your schema validation errors would be ignored, leading to the strange behaviour that implementing Validator and returning no errors would cause the incorrectly ignored schema errors to surface.

@k8s-ci-robot
Copy link
Contributor

@KnVerey: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 9, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2022
@KnVerey KnVerey changed the title Configure templateparser fn framework: bugfix for schema providers + configurable template extensions May 9, 2022
@natasha41575
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2022
@natasha41575
Copy link
Contributor

natasha41575 commented May 9, 2022

I'm wondering if we should disable the error wrap lint check, is it important that we ensure all errors are wrapped correctly?

Edit: I'm happy with the change you just pushed!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KnVerey,natasha41575]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KnVerey
Copy link
Contributor Author

KnVerey commented May 9, 2022

I'm wondering if we should disable the error wrap lint check, is it important that we ensure all errors are wrapped correctly?

The linter doesn't complain about all errors--in this case, it is complaining that I'm not wrapping an error from an external package, which seems like a reasonable policy to have to help with debugging. Here's an explanation of when that linter will complain: https://blog.tomarrell.com/post/introducing_wrapcheck_linter_for_go

@natasha41575
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit c3b5d8f into kubernetes-sigs:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants