New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fn framework: bugfix for schema providers + configurable template extensions #4629
fn framework: bugfix for schema providers + configurable template extensions #4629
Conversation
@KnVerey: This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
I'm wondering if we should disable the error wrap lint check, is it important that we ensure all errors are wrapped correctly? Edit: I'm happy with the change you just pushed! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KnVerey, natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The linter doesn't complain about all errors--in this case, it is complaining that I'm not wrapping an error from an external package, which seems like a reasonable policy to have to help with debugging. Here's an explanation of when that linter will complain: https://blog.tomarrell.com/post/introducing_wrapcheck_linter_for_go |
/lgtm |
A small enhancement and a bug fix for the functions framework, in separate commits:
.template.yaml
, which is non-standard. This allows one or more other extensions to be explicitly targeted.