New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tagsuffix to take image tag suffix #4364
add tagsuffix to take image tag suffix #4364
Conversation
Welcome @DiptoChakrabarty! |
Hi @DiptoChakrabarty. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@DiptoChakrabarty: This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
api/types/image.go
Outdated
// NewTag is the value used to replace the original tag. | ||
// If newtag is present TagSuffix value is ignored | ||
NewTag string `json:"newTag,omitempty" yaml:"newTag,omitempty"` | ||
|
||
// Digest is the value used to replace the original image tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update these comments to explain the difference between digest
and newTag
? As it is, it sounds like they should do the exact same thing but that is not the case.
/ok-to-test |
/lgtm |
please fix the CI failure! https://github.com/kubernetes-sigs/kustomize/runs/4743248529?check_suite_focus=true |
/lgtm |
just rebased it and tried fixing the yaml examples in tests |
bdd0e6d
to
f1efd4d
Compare
hey @natasha41575 the test passed , there was an issue with spaces in the yaml tests |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DiptoChakrabarty, natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
remove tabs in yamls fix space in image name tag error in name
format of yaml set example as above
f088c4e
to
489b01b
Compare
@natasha41575 fixed the testcases |
/lgtm |
Fix #4322
A new parameter tagSuffix has been added in the Image struct which considers the suffix to an existing tag , if present the suffix is appended to the current tag and image is updated.
Not sure if test is needed and if yes should it go on this file