prevent internal annotations from showing up in the errors thrown by filters #4352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
natasha41575
force-pushed
the
FilterErrors
branch
2 times, most recently
from
74dd1a9
to
3187687
Compare
|
Looks good, but there's still one more spot to update according to the test failures |
natasha41575
force-pushed
the
FilterErrors
branch
from
3187687
to
c659306
Compare
|
/cc @yuwenma |
|
/lgtm qq: Do we have a strategy on adding new kyaml functions? |
k8s-ci-robot
added
the
lgtm
Not sure what you mean by strategy, but Mengqi is working on improving kyaml and the function authoring experience: #4319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent internal annotations from showing up in the errors thrown by filters by surfacing just the object's ResId rather than its entire content.
There is one more place where the internal id shows up (in cmd/config, when running
kustomize fn run), still working on figuring out why it shows up there and will make that fix in a separate PR./cc @KnVerey