Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move api/internal/git to api/git. #4231

Closed
Bolodya1997 opened this issue Oct 8, 2021 · 3 comments
Closed

Move api/internal/git to api/git. #4231

Bolodya1997 opened this issue Oct 8, 2021 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@Bolodya1997
Copy link

Is your feature request related to a problem? Please describe.

I am implementing some code to prefetch all used images referenced from kustomize.yaml before processing kubectl apply -k - it is needed to improve tests stability. To work with remote bases I am currently using https://github.com/kubernetes-sigs/kustomize/blob/master/api/internal/git/repospec.go for extracting git repo spec from URL and further processing it, and it is very helpful.
Unfortunately it is located in api/internal/git package, so it cannot be imported and can only be copy-pasted and so it probably will need to be manually updated in some future.

Describe the solution you'd like

Can it be moved from api/internal/git package to just api/git?

@Bolodya1997 Bolodya1997 added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 8, 2021
@k8s-ci-robot
Copy link
Contributor

@Bolodya1997: This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 8, 2021
@natasha41575
Copy link
Contributor

In preparation for releasing v1 of the api module, we would like to reduce its public surface. This will help us maintain backwards compatibility and allow more flexibility in our implementation of kustomize. See #3942

Because we are trying to reduce the public surface of the api module, I'm very hesitant to consider moving things out of api/internal. The api/internal/git package was never intended to be used as a library and exposing it would place the burden on us to maintain it as such. As far as we are concerned, it is just an implementation detail for how kustomize fetches remote resources.

I am implementing some code to prefetch all used images referenced from kustomize.yaml

Are you trying to implement something similar to #3980, which proposes a kustomize localize command? It may make more sense for kustomize to have your use case a builtin feature, rather than exposing internal details as a library for others to build it.

@natasha41575 natasha41575 added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 14, 2021
@natasha41575
Copy link
Contributor

Closing as I don't think we would like t support this request at the moment. Please feel free to respond if you have further questions or concerns!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

3 participants