Do YAML anchor expansion shortly after reading YAML. #4187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: monopole The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
monopole
force-pushed
the
deanchorCall
branch
from
109ad15
to
287ed9f
Compare
monopole
requested review from
natasha41575
and removed request for
phanimarupaka
monopole
force-pushed
the
deanchorCall
branch
2 times, most recently
from
3b0ee07
to
448bad2
Compare
k8s-ci-robot
added
size/L
monopole
force-pushed
the
deanchorCall
branch
from
448bad2
to
24436a9
Compare
monopole
force-pushed
the
deanchorCall
branch
from
24436a9
to
dce4ea5
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code now replaces YAML aliases with their anchor definitions immediately after reading YAML within
kio.FromBytes.The added code balanced a bit by factoring the List expansion code to another method (
inlineAnyEmbeddedLists).Fixes #3675
ALLOW_MODULE_SPAN