Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support multiple gvks in custom openapi schema #4163

Merged
merged 1 commit into from Sep 16, 2021
Merged

support multiple gvks in custom openapi schema #4163

merged 1 commit into from Sep 16, 2021

Conversation

natasha41575
Copy link
Contributor

@natasha41575 natasha41575 commented Sep 2, 2021 •
edited

Fix #4127

ALLOW_MODULE_SPAN

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 2, 2021
@KnVerey
Copy link
Contributor

KnVerey commented Sep 3, 2021

How much trouble would it be to add a regression test based on the example provided in the issue?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 16, 2021
@natasha41575
Copy link
Contributor Author

How much trouble would it be to add a regression test based on the example provided in the issue?

I added a regression test that verified multiple GVKs are supported, though instead of being specifically based on the example provided in the issue, it is based on the other examples we have in our custom OpenAPI schema tests.

@natasha41575
Copy link
Contributor Author

/retest

@KnVerey
Copy link
Contributor

KnVerey commented Sep 16, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit c1ae234 into kubernetes-sigs:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monopole monopole Awaiting requested review from monopole

@KnVerey KnVerey Awaiting requested review from KnVerey

Assignees

@KnVerey KnVerey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kustomize does not support multiple "x-kubernetes-group-version-kind" in OpenAPI
3 participants
@natasha41575 @k8s-ci-robot @KnVerey