Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support yaml formatted openapi schema #4017

Merged
merged 2 commits into from Jul 15, 2021
Merged

support yaml formatted openapi schema #4017

merged 2 commits into from Jul 15, 2021

Conversation

natasha41575
Copy link
Contributor

@natasha41575 natasha41575 commented Jun 25, 2021 •
edited

addresses #3961

ALLOW_MODULE_SPAN

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 25, 2021
@natasha41575
Copy link
Contributor Author

/test kustomize-presubmit-master

@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jun 26, 2021
@natasha41575 natasha41575 linked an issue Jun 26, 2021 that may be closed by this pull request
Support YAML formatted OpenAPI schema #3961
Closed
KnVerey
KnVerey reviewed Jun 30, 2021
View reviewed changes
kustomize/commands/openapi/fetch/fetch.go Outdated Show resolved Hide resolved
kyaml/go.mod Show resolved Hide resolved
kyaml/openapi/openapi.go Outdated Show resolved Hide resolved
@natasha41575 natasha41575 requested a review from KnVerey July 2, 2021 22:15
@natasha41575 natasha41575 force-pushed the yamlopenapi branch 2 times, most recently from e9ad5a7 to 6c56a99 Compare July 2, 2021 22:45
@natasha41575
Copy link
Contributor Author

@KnVerey If you get a chance, this could use another review, thanks!.

KnVerey
KnVerey reviewed Jul 14, 2021
View reviewed changes
kyaml/openapi/openapi.go Outdated
@@ -15,7 +15,8 @@ import (
"sigs.k8s.io/kustomize/kyaml/errors"
"sigs.k8s.io/kustomize/kyaml/openapi/kubernetesapi"
"sigs.k8s.io/kustomize/kyaml/openapi/kustomizationapi"
"sigs.k8s.io/kustomize/kyaml/yaml"
kyaml "sigs.k8s.io/kustomize/kyaml/yaml"
"sigs.k8s.io/yaml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what we've done elsewhere when multiple yaml libs have to be used? If not, I'd suggest leaving kyaml as yaml since that's what folks changing this file should use by default, and make sig.k8s.io/yaml the one with an alias

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

kyaml/openapi/openapi.go Outdated Show resolved Hide resolved
kustomize/commands/openapi/fetch/fetch.go Outdated Show resolved Hide resolved
@natasha41575 natasha41575 added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 15, 2021
@k8s-ci-robot
Copy link
Contributor

@natasha41575: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@natasha41575
Copy link
Contributor Author

/cc @KnVerey

KnVerey
KnVerey approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@KnVerey KnVerey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KnVerey,natasha41575]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0537b59 into kubernetes-sigs:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnVerey KnVerey KnVerey approved these changes

@monopole monopole Awaiting requested review from monopole

@mortent mortent Awaiting requested review from mortent

Assignees

@KnVerey KnVerey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support YAML formatted OpenAPI schema
3 participants
@natasha41575 @k8s-ci-robot @KnVerey