Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to gopkg.in/yaml.v2 v2.4.0 #3664

Closed
monopole opened this issue Mar 3, 2021 · 2 comments · Fixed by #3667
Closed

Upgrade to gopkg.in/yaml.v2 v2.4.0 #3664

monopole opened this issue Mar 3, 2021 · 2 comments · Fixed by #3667
Assignees
@natasha41575

Comments

@monopole
Copy link
Contributor

monopole commented Mar 3, 2021 •
edited

Blocks #1500, related to kubernetes/kubernetes#98946

Both the api/go.mod and kyaml/go.mod are pinned to v2.3.0, but this has a problem: go-yaml/yaml#670

What happens if we change to v2.4.0?
@natasha41575
Copy link
Contributor

Looks like all this changes is a few unit tests. It appears that there is a line length limit in v2.4.0 and long lines are given line breaks and continue to the next line. Will make a PR to show the changes

@natasha41575 natasha41575 self-assigned this Mar 3, 2021
@natasha41575 natasha41575 mentioned this issue Mar 3, 2021
Merged
@monopole
Copy link
Contributor Author

monopole commented Mar 3, 2021

line breaks are expected 👍

@KnVerey KnVerey mentioned this issue Apr 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natasha41575 natasha41575

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgraded to yaml.v2 v2.4.0 natasha41575/kustomize
2 participants
@monopole @natasha41575