From a32228b8b7a28e19e4096fead150de9023e321e5 Mon Sep 17 00:00:00 2001 From: natasha41575 Date: Thu, 7 Apr 2022 14:54:13 -0700 Subject: [PATCH] fix issue with replacements --- api/filters/replacement/replacement.go | 3 --- api/filters/replacement/replacement_test.go | 23 ++++++++++++++++++++- 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/api/filters/replacement/replacement.go b/api/filters/replacement/replacement.go index a96dfff7195..76cb6089ffd 100644 --- a/api/filters/replacement/replacement.go +++ b/api/filters/replacement/replacement.go @@ -142,9 +142,6 @@ func applyToOneNode(options *types.FieldOptions, t *yaml.RNode, value *yaml.RNod } for _, scalarNode := range t.YNode().Content { - if options != nil && options.Create { - return fmt.Errorf("cannot use create option in a multi-value target") - } rn := yaml.NewRNode(scalarNode) if err := setTargetValue(options, rn, value); err != nil { return err diff --git a/api/filters/replacement/replacement_test.go b/api/filters/replacement/replacement_test.go index db25ce37202..669207fca55 100644 --- a/api/filters/replacement/replacement_test.go +++ b/api/filters/replacement/replacement_test.go @@ -2347,7 +2347,28 @@ spec: options: create: true `, - expectedErr: `cannot use create option in a multi-value target`, + expected: ` +apiVersion: batch/v1 +kind: Job +metadata: + name: hello +spec: + template: + spec: + containers: + - image: busybox + name: myapp-container + restartPolicy: OnFailure +--- +apiVersion: v1 +kind: Pod +metadata: + name: my-pod +spec: + containers: + - image: busybox + name: myapp-container + restartPolicy: OnFailure`, }, }