From 3d74348d947cd74a1527712c6b54979282276e5c Mon Sep 17 00:00:00 2001 From: Adrian Orive Date: Tue, 2 Feb 2021 15:02:11 +0100 Subject: [PATCH] Skip descriptiveness check if the "skip-descriptiveness-check" flag is set. Signed-off-by: Adrian Orive --- verify/descriptiveness.go | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/verify/descriptiveness.go b/verify/descriptiveness.go index bf20ffd..5c04ce5 100644 --- a/verify/descriptiveness.go +++ b/verify/descriptiveness.go @@ -17,11 +17,15 @@ limitations under the License. package main import ( + "strings" + "github.com/google/go-github/v32/github" "sigs.k8s.io/kubebuilder-release-tools/verify/pkg/action" ) +const skipDescriptivenessCheckLabel = "skip-descriptiveness-check" + type prDescriptivenessError struct{} func (e prDescriptivenessError) Error() string { @@ -36,7 +40,13 @@ Someone reading the PR description without clicking any issue links should be ab // checkPRDescriptiveness func checkPRDescriptiveness(requiredCharacters int) action.ValidateFunc { return func(pr *github.PullRequest) (string, string, error) { - if len(pr.GetBody()) < requiredCharacters { + for _, label := range pr.Labels { + if label.Name != nil && *label.Name == skipDescriptivenessCheckLabel { + return "Skipping descriptiveness check!", "", nil + } + } + + if len(strings.TrimSpace(pr.GetBody())) < requiredCharacters { return "", "", &prDescriptivenessError{} } return "Your PR looks descriptive enough!", "", nil