PoC: implement syncer #335
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
sig/scheduling
k8s-ci-robot
added
approved
sanposhiho
force-pushed
the
syncer
branch
4 times, most recently
from
5c3ba58
to
d2a0239
Compare
k8s-ci-robot
added
the
needs-rebase
sanposhiho
force-pushed
the
syncer
branch
2 times, most recently
from
7511587
to
c4645f3
Compare
k8s-ci-robot
removed
the
needs-rebase
sanposhiho
force-pushed
the
syncer
branch
2 times, most recently
from
4be4172
to
f170bfd
Compare
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area simulator
/kind feature
What this PR does / why we need it:
Implement syncer which keep copying the resources from the external kube-apiserver to the simulator's one.
It's based on #333 so that it won't be hard to rebase in the future.
Which issue(s) this PR fixes:
Fixes #327
Special notes for your reviewer:
/label tide/merge-method-squash