Support extender on external scheduler #321
Conversation
k8s-ci-robot
added
area/simulator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 196Ikuchil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
sig/scheduling
k8s-ci-robot
added
approved
|
Oops, I forgot to fix the /hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
| @@ -26,83 +26,87 @@ import ( | |||
| simulatorconfig "sigs.k8s.io/kube-scheduler-simulator/simulator/config" | |||
There was a problem hiding this comment.
We don't need to think about the external scheduler package anymore. If people want to use a new feature by this feature, they can just move to debuggable scheduler package.
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/area simulator
/kind feature
What this PR does / why we need it:
TODO
Which issue(s) this PR fixes:
Fixes #291
Results
Tested in my local.
$ k apply -f example3/configs/test-pod1.yaml $ k describe pod annotation-second-scheduler Name: annotation-second-scheduler Namespace: default Priority: 0 Service Account: default Node: multinode-demo-m02/192.168.49.3 Start Time: Mon, 14 Aug 2023 00:33:39 +0900 Labels: name=multischeduler-example Annotations: noderesourcefit-prefilter-data: {"MilliCPU":0,"Memory":0,"EphemeralStorage":0,"AllowedPodNumber":0,"ScalarResources":null} scheduler-simulator/bind-result: {"DefaultBinder":"success"} scheduler-simulator/extender-bind-result: {} scheduler-simulator/extender-filter-result: {"http://localhost:8080/scheduler/":{"Nodes":{"metadata":{},"items":[{"metadata":{"name":"multinode-demo","uid":"c0a513f5-a00c-4eee-a72a-e... scheduler-simulator/extender-preempt-result: {} scheduler-simulator/extender-prioritize-result: {"http://localhost:8080/scheduler/":[{"Host":"multinode-demo","Score":0},{"Host":"multinode-demo-m02","Score":0}]} scheduler-simulator/filter-result: {"multinode-demo":{"AzureDiskLimits":"passed","EBSLimits":"passed","GCEPDLimits":"passed","InterPodAffinity":"passed","NodeAffinity":"pass... scheduler-simulator/finalscore-result: {"multinode-demo":{"ImageLocality":"0","InterPodAffinity":"0","NodeAffinity":"0","NodeNumber":"0","NodeResourcesBalancedAllocation":"80","... scheduler-simulator/permit-result: {} scheduler-simulator/permit-result-timeout: {} scheduler-simulator/postfilter-result: {} scheduler-simulator/prebind-result: {"VolumeBinding":"success"} scheduler-simulator/prefilter-result: {} scheduler-simulator/prefilter-result-status: {"InterPodAffinity":"success","NodeAffinity":"success","NodePorts":"success","NodeResourcesFit":"success","PodTopologySpread":"success","V... scheduler-simulator/prescore-result: {"InterPodAffinity":"success","NodeAffinity":"success","NodeNumber":"success","PodTopologySpread":"success","TaintToleration":"success"} scheduler-simulator/reserve-result: {"VolumeBinding":"success"} scheduler-simulator/result-history: [{"noderesourcefit-prefilter-data":"{\"MilliCPU\":0,\"Memory\":0,\"EphemeralStorage\":0,\"AllowedPodNumber\":0,\"ScalarResources\":null}",... scheduler-simulator/score-result: {"multinode-demo":{"ImageLocality":"0","InterPodAffinity":"0","NodeAffinity":"0","NodeNumber":"0","NodeResourcesBalancedAllocation":"80","... scheduler-simulator/selected-node: multinode-demo-m02 Status: Running(Formatted↓)
Special notes for your reviewer:
In order to resolve issue 318 in the near future, I'd like to split the
CreateOptionForOutOfTreePlugin()process by purpose./assign @sanposhiho
/label tide/merge-method-squash