Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the fetch when a resource is selected on the webUI. #234

Open
196Ikuchil opened this issue Sep 25, 2022 · 4 comments
Open

Stop the fetch when a resource is selected on the webUI. #234

196Ikuchil opened this issue Sep 25, 2022 · 4 comments
Labels
area/web Issues or PRs related to the Web UI. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@196Ikuchil
Copy link
Contributor

Issue

Currently, a fetch request will occur if you select a resource on webUI.

watch(selected, (newVal, oldVal) => {

However, we implement the new feature #211. So, we would not need to use this logic.
(Actually, I forgot to remove these...)

/area web
/kind cleanup

@k8s-ci-robot k8s-ci-robot added area/web Issues or PRs related to the Web UI. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 25, 2022
@196Ikuchil
Copy link
Contributor Author

There are some concerns.
We must consider the schedulerconfiguration and other resources which will not update automatically (This does not exist currently, I think).

@sanposhiho
Copy link
Member

👍

We must consider the schedulerconfiguration

Two options here:

  • provide schedulerconfiguration's update event from watch API as other k8s resources.
  • remove fetching resources only. and fetch schedulerconfiguration when it's selected as web UI does now.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 1, 2023
@sanposhiho
Copy link
Member

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web Issues or PRs related to the Web UI. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

4 participants