Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish preparing for v0.6.0-rc2 release #1608

Merged
merged 2 commits into from Dec 16, 2022
Merged

Finish preparing for v0.6.0-rc2 release #1608

merged 2 commits into from Dec 16, 2022

Conversation

shaneutt
Copy link
Member

What this PR does / why we need it:

This makes the remaining changes needed to release v0.6.0-rc2.

@shaneutt
Finish preparing for v0.6.0-rc2 release
e247332 
Signed-off-by: Shane Utt <shaneutt@linux.com>
@shaneutt shaneutt added this to the v0.6.0 milestone Dec 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 16, 2022
shaneutt
shaneutt commented Dec 16, 2022
View reviewed changes
Copy link
Member Author

@shaneutt shaneutt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Includes only the pkg/generator/main.go updates and BASE_REF=v0.6.0-rc2 make generate changes needed to cut the pre-release.

@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Dec 16, 2022
@shaneutt shaneutt added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 16, 2022
@shaneutt shaneutt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2022
@robscott
Copy link
Member

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 889b226 into kubernetes-sigs:main Dec 16, 2022
@shaneutt shaneutt deleted the shaneutt/release-v060-rc2 branch December 16, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@robscott robscott Awaiting requested review from robscott

@youngnick youngnick Awaiting requested review from youngnick

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shaneutt @k8s-ci-robot @robscott