Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ReferencePolicy in favor of ReferenceGrant #1406

Merged
merged 1 commit into from Sep 26, 2022

Conversation

robscott
Copy link
Member

What type of PR is this?
/kind cleanup
/kind deprecation

What this PR does / why we need it:
ReferencePolicy was renamed to ReferenceGrant in v0.5.0. The original ReferencePolicy resource was formally deprecated at that point, this removes it entirely.

Does this PR introduce a user-facing change?:

ReferencePolicy has been removed from the API in favor of ReferenceGrant.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 26, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 26, 2022
ReferencePolicy was renamed to ReferenceGrant in v0.5.0. The original
ReferencePolicy resource was formally deprecated at that point, this
removes it entirely.
@robscott robscott added this to the v0.6.0 milestone Sep 26, 2022
@robscott
Copy link
Member Author

Fixes #1206

@mikemorris
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit a8f619d into kubernetes-sigs:main Sep 26, 2022
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: keithmattix, robscott, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

howardjohn added a commit to howardjohn/gateway-api that referenced this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ReferencePolicy in favor of ReferenceGrant before v0.6.0 release
5 participants