✨ crd/gen: sort FindKubeKinds

[gshirazi]

Fixes #675 by sorting kubeKinds in FindKubeKinds

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: gshirazi / name: Ghasem Shirazi (36518f6)

[k8s-ci-robot]

Welcome @gshirazi!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @gshirazi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gshirazi]

@ahmetb kindly plz review

[ahmetb]

Seems to be working reproducibly and sorting kinds as expected. Thanks.
/lgtm

[ahmetb]

needs rebase after #682 is merged.

[alvaroaleman]

@gshirazi could you please add a test for this?

[alvaroaleman]

/retest

[ahmetb]

@gshirazi could you please add a test for this?

at a high level, the Generate() function is largely untested, so I am not sure if it'll be a fair ask to add tests for this without while missing tests for the actual functionality.

but there seems to be some integration tests, so maybe it's possible to write one that captures +output:stdout case.

[alvaroaleman]

By "this" I meant for this functionality. The PR is based on an older version of the master branch where I think this was deterministic regardless of the sorting and it seems it got broken in 81d0342

If we don't add a test, this will just regress again sooner or later so there is no point in fixing it.

[gshirazi]

I see,

pkg/crd/gen.go:275:20: cannot use i (variable of type int) as schema.GroupKind value in map index (typecheck)

I need to rebase this based on the latest master (map not slice). Then add some integration test.

[gshirazi]

any objections to reverting 81d0342 ?

[alvaroaleman]

any objections to reverting 81d0342 ?

Yes, it was added to de-duplicate. Please just copy the map keys into a slice and sort that slice rather than reverting anything. Also, we are not going to merge anything here until there are tests.

[gshirazi]

@alvaroaleman @ahmetb added tests. please review, thanks.

[gshirazi]

@alvaroaleman @ahmetb added tests. please review, thanks.

any feedback?

[ahmetb]

Sorry, I'm not very initiated in this repository. I will defer to others.

[alvaroaleman]

/ok-to-test

[alvaroaleman]

@gshirazi I can't comment on it, but you checked in a binary cmd/main. Please remove that, other than that the change looks good to me.
/hold

[gshirazi]

done.

[alvaroaleman]

/label tide/merge-method-squash

[alvaroaleman]

/lgtm
/approve
/hold cancel

Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, gshirazi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alvaroaleman]

/cherrypick release-0.9

[k8s-infra-cherrypick-robot]

@alvaroaleman: new pull request created: #694

In response to this:

/cherrypick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.