You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We ran into a case of config/webhook/manifests.yaml changing unexpectedly - that is, without any changes/additions to the existing webhooks.
I can't share the source of our project and I don't have another repo at the moment, but I'll share one if I can reproduce this with sample code. For context, we have two API versions in our project: v1 and v1alpha1.
After adding an import of the v1alpha1 package in code unrelated to webhooks, controller-gen changed the order of the webhook definitions in manifests.yaml. I was able to trace this back to a difference in the order in which controller-gentraverses packages - with the new import, it visits v1alpha1 first; without the new import, it visits v1 first.
I would expect that webhook/manifests.yaml should be stable when there are no changes that involve webhooks. I'm not sure if the appropriate fix here would be in the webhook parser (e.g. an additional sort based on the API version) or in how controller-gen visits packages.
The text was updated successfully, but these errors were encountered:
Also not sure where to fix this ideally, but sounds like something we should fix. Maybe it's easier in a place close to where we generate the output manifests to not affect other parts of the code.
Ideally we would do it without producing churn compared to what we generate today. But I think that will be impossible.
We ran into a case of
config/webhook/manifests.yaml
changing unexpectedly - that is, without any changes/additions to the existing webhooks.I can't share the source of our project and I don't have another repo at the moment, but I'll share one if I can reproduce this with sample code. For context, we have two API versions in our project:
v1
andv1alpha1
.After adding an import of the
v1alpha1
package in code unrelated to webhooks,controller-gen
changed the order of the webhook definitions inmanifests.yaml
. I was able to trace this back to a difference in the order in whichcontroller-gen
traverses packages - with the new import, it visitsv1alpha1
first; without the new import, it visitsv1
first.I would expect that
webhook/manifests.yaml
should be stable when there are no changes that involve webhooks. I'm not sure if the appropriate fix here would be in the webhook parser (e.g. an additional sort based on the API version) or in howcontroller-gen
visits packages.The text was updated successfully, but these errors were encountered: