Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller-gen fails to handle individual file in paths #837

Open
mmingdai opened this issue Jul 26, 2023 · 4 comments · May be fixed by #864
Open

controller-gen fails to handle individual file in paths #837

mmingdai opened this issue Jul 26, 2023 · 4 comments · May be fixed by #864
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@mmingdai
Copy link

mmingdai commented Jul 26, 2023 •
edited

controller-gen treats the file as a package, which causes error. This command works in v0.7.0. I think it's due to #663
Specifically this part
https://github.com/kubernetes-sigs/controller-tools/pull/663/files#diff-19effe657639f31c4b607076be411e82add5f6cc176fc7c26555020ff9663cbdR562
@mmingdai
Copy link
Author

@akutz

@mmingdai mmingdai mentioned this issue Jul 26, 2023
Merged
yongxiu pushed a commit to yongxiu/controller-tools that referenced this issue Nov 30, 2023
Fix controller-tools doesn't support single files as input
4197a9b 
kubernetes-sigs#837
@yongxiu yongxiu linked a pull request Nov 30, 2023 that will close this issue
Open
yongxiu added a commit to yongxiu/controller-tools that referenced this issue Nov 30, 2023
@yongxiu
Fix controller-tools doesn't support single files as input
39e518a 
kubernetes-sigs#837
yongxiu added a commit to yongxiu/controller-tools that referenced this issue Nov 30, 2023
@yongxiu
Fix controller-tools doesn't support single files as input
8049ce8 
kubernetes-sigs#837
yongxiu added a commit to yongxiu/controller-tools that referenced this issue Dec 7, 2023
@yongxiu
Fix controller-tools doesn't support single files as input
6f0d732 
kubernetes-sigs#837
yongxiu added a commit to yongxiu/controller-tools that referenced this issue Dec 8, 2023
@yongxiu
Fix controller-tools doesn't support single files as input
ed8e31d 
kubernetes-sigs#837
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2024
@yongxiu
Copy link

yongxiu commented Jan 28, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2024
yongxiu added a commit to yongxiu/controller-tools that referenced this issue Mar 29, 2024
@yongxiu
Fix controller-tools doesn't support single files as input
dabf09d 
kubernetes-sigs#837
@AndreiBarbuOz AndreiBarbuOz mentioned this issue Apr 12, 2024
Closed
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Fix controller-tools doesn't support single files as input yongxiu/controller-tools
4 participants
@yongxiu @mmingdai @k8s-ci-robot @k8s-triage-robot